Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level 5 loading #33

Closed
anastasia-horbachevska opened this issue Apr 6, 2020 · 2 comments
Closed

Level 5 loading #33

anastasia-horbachevska opened this issue Apr 6, 2020 · 2 comments

Comments

@anastasia-horbachevska
Copy link

Description:

Level 5 takes longer to load than the previous and subsequent levels. need to wait more than 5 seconds.

Steps to reproduce:

  1. Open the link https://duckhuntjs.com.
  2. Start the game.
  3. Play up to level 5.

Actual result:

Level 5 takes longer to load.

Expected result:

The level will load at the same speed as the other levels.

Additional info:

Tested on Chrome.

@MattSurabian
Copy link
Owner

Thanks for opening this issue!

I suspect this experience is due to how I lazily implemented the dogs retrieve behavior. Level 4 has lots of ducks in each wave and the dog currently will animate and retrieve every single one that gets shot so it's possible if you're a particularly fast or otherwise skilled player that the level ends so quickly the dog is left bobbing up and down trying to clean up everything, while also sometimes seeing there are 0 ducks left and laughing along the way. The end result is that players have to sit through that instead of just moving on to level 5.

I'll try to fix this and update some underlying deps, been a while since I've been in this codebase.

@MattSurabian
Copy link
Owner

Finally addressed this. Thanks again for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants