Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: 'nixinate' is not a valid system type #12

Open
wyndon opened this issue Mar 15, 2022 · 7 comments
Open

error: 'nixinate' is not a valid system type #12

wyndon opened this issue Mar 15, 2022 · 7 comments

Comments

@wyndon
Copy link

wyndon commented Mar 15, 2022

When running nix flake check, it complains about nixinate not being a valid system type

❯ nix flake check
error: 'nixinate' is not a valid system type, at /nix/store/n3gxibvxm0i4zkdb5s6dkalwsyr5qni6-source/flake.nix:46:14
(use '--show-trace' to show detailed location information)
@MatthewCroughan
Copy link
Owner

The apps attribute of the flake schema wants to disallow a nested attributes like apps.myName.myNestedApp.x86_64-linux, but I believe this should be changed. So this issue may remain until the flake schema changes, or 3.0 is released which settles any debate on it.

@ursi
Copy link
Contributor

ursi commented Oct 4, 2022

I feel like breaking nix flake check is too big of a price to pay. It seems that the only thing you want nested apps for is so you can go nixinate.foo. For now, why not just make it nixinate-foo or nixinate_foo so we can use it with nix flake check? Or at least make an alternative function that can be used for those of us that need nix flake check.

@MatthewCroughan
Copy link
Owner

@ursi it's important to remember that flakes aren't stable, and that we shouldn't program with the expectation of any stability until they are. So with that in mind, it's entirely still possible to make Flakes work more like we would like them to, and to argue the point upstream.

@Kranzes
Copy link

Kranzes commented Oct 5, 2022

I think that for the meantime we should go with what @ursi proposed, making the apps flat and prefixing them with nixinate-.

@ursi
Copy link
Contributor

ursi commented Oct 5, 2022

What I have done as a workaround for now is apps.x86_64-linux = (nixinate stuff).nixinate. If I wanted the nixinate prefix on the app names I could use lib.mapAttrs', but for my current project, that's not necessary.

@quinn-dougherty
Copy link

(oops, duplicated) #31

@Stunkymonkey
Copy link

@MatthewCroughan i guess you are talking about: NixOS/nix#6381 ? is there a more up-to-date discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants