Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error opening Requests tab #501

Open
2 tasks
joe-crawford opened this issue Jan 15, 2025 · 4 comments
Open
2 tasks

Error opening Requests tab #501

joe-crawford opened this issue Jan 15, 2025 · 4 comments
Assignees
Labels
bug Something isn't working epic

Comments

@joe-crawford
Copy link
Contributor

joe-crawford commented Jan 15, 2025

Description

Error on loading Requests tab

Steps to reproduce

Log in to User Portal, click on Requests, error appears:

 Cannot read properties of null (reading 'organisationId')

Expected behavior

Requests should be loaded

Screenshots

Screenshot 2025-01-15 at 17 19 38

Environment

recent develop build, on an instance which had some requests previously created

Solution

The issue described here will be fixed when the following tasks are completed:

@joe-crawford joe-crawford added the bug Something isn't working label Jan 15, 2025
@joe-crawford
Copy link
Contributor Author

Test system already has Users and Requests loaded into it so hopefully the resolution to this can include a migration that will fix the data that is problematic in that system.

Users are currently in the test system and adding New User Requests

@NigelPalmer
Copy link
Contributor

NigelPalmer commented Jan 16, 2025

There are a number of things going on here:

  1. The users in question do not have an organisation membership. Therefore when they log in they should be taken to a different landing page with limited access to the User Portal, and this error should not appear. See: Prevent a research user from carrying out actions when they are not part of an Organisation #450
  2. Assignment of Organisation memberships will be achievable using the Admin Portal. A lot of this functionality is already there, but we need to get it complete. Therefore a script should not be required, since admins will be able to deal with this manually. Created https://github.com/MauroDataMapper/sde-resources/issues/225 to address this.

@joe-crawford
Copy link
Contributor Author

That's useful, thanks for the comment @NigelPalmer.

Would like to keep this GH ticket so we can track it in our testing but can move from the board if you've already got the components there.

@NigelPalmer
Copy link
Contributor

@joe-crawford , happy to keep this ticket to track this work. I will make it an Epic.

@NigelPalmer NigelPalmer self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic
Projects
None yet
Development

No branches or pull requests

2 participants