Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dependencies preventing an upgrade to Angular 13 or higher #554

Closed
pjmonks opened this issue May 30, 2022 · 1 comment · Fixed by #738
Closed

Package dependencies preventing an upgrade to Angular 13 or higher #554

pjmonks opened this issue May 30, 2022 · 1 comment · Fixed by #738
Labels
bug Something isn't working dependencies Pull requests that update a dependency file maintenance General maintenance on this repo or application

Comments

@pjmonks
Copy link
Contributor

pjmonks commented May 30, 2022

I was attempting an upgrade from Angular 12 to 13 for mdm-ui to try and resolve peer dependency issues. The upgrade process involves:

  1. Removing the local package-lock.json file
  2. Deleting all node_modules already on your local machine (to avoid conflicts)
  3. Copy original list of dependencies from package.json before making modifications.
  4. Overwrite all package dependencies with latest versions of Angular packages
  5. Run npm install
  6. Then add back additional and 3rd party packages that the Angular upgrade process does not know about.

However, the process highlighted these package dependencies which will prevent an upgrade to Angular 13 because they do not support the latest version of Angular

  1. angular-user-idle
  2. jodit-angular

angular-user-idle is no longer supported. The mdm-explorer repo gets around this issue by directly importing the source code (with credit to the original authors) into the repo, maintaining it's own forked copy.

jodit-angular has this open issue for Angular 13 support - jodit/jodit-angular#101 - but has not been completed (as of creating this issue).

Both of these are blockers for an Angular 13 upgrade.

@pjmonks pjmonks added bug Something isn't working dependencies Pull requests that update a dependency file maintenance General maintenance on this repo or application labels May 30, 2022
@pjmonks pjmonks moved this to Backlog in MDM State May 30, 2022
@pjmonks
Copy link
Contributor Author

pjmonks commented May 31, 2022

It should be pointed out that jodit-angular is actually just a wrapper around the core jodit package, and the code is minimal (one component) to contain the actual Jodit HTML editor DOM elements. So it is possible, like angular-user-idle, to maintain our own copy of the Angular component wrapper and only depend directly on jodit core.

@pjmonks pjmonks changed the title Package dependencies preventing an upgrade to Angular 13 Package dependencies preventing an upgrade to Angular 13 or higher Jun 7, 2022
@github-project-automation github-project-automation bot moved this from Backlog to Merged to Develop / Waiting to release in MDM State Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file maintenance General maintenance on this repo or application
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

1 participant