Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat-progress-spinner component jumps in safari #608

Closed
jamesrwelch opened this issue Jul 18, 2022 · 8 comments · Fixed by #738
Closed

mat-progress-spinner component jumps in safari #608

jamesrwelch opened this issue Jul 18, 2022 · 8 comments · Fixed by #738
Labels
bug Something isn't working on hold Issue has been placed on hold to resolve later

Comments

@jamesrwelch
Copy link
Contributor

In safari on a Mac, the <mat-progress-spinner> component jumps around and looks very unappealing. This might be a styling issue, or maybe we need a new component. Will try and upload a video to demonstrate if I can work out how.

@jamesrwelch
Copy link
Contributor Author

mat-progress-spinner

@jamesrwelch
Copy link
Contributor Author

This may just be an issue when the browser zoom is not 100%. People with sensible eyesight, or sensible screens, may not have the same problem.

@jamesrwelch
Copy link
Contributor Author

Not an issue on this page, however: https://material.angular.io/components/progress-spinner/overview

@jamesrwelch
Copy link
Contributor Author

This fix sounds like the right one, and after playing, can confirm that it's to do with the transform-origin setting

@jamesrwelch jamesrwelch added the on hold Issue has been placed on hold to resolve later label Jul 18, 2022
@pjmonks
Copy link
Contributor

pjmonks commented Jul 18, 2022

@jamesrwelch Were you referring to a fix you've found somewhere? If so could you elaborate so someone could pick this up? I don't run Safari so would never have known this was an issue.

@jamesrwelch
Copy link
Contributor Author

@pjmonks Yep, sorry, meant to link here: angular/components#23674. We'll need to upgrade angular material components to get the fix, as far as I can see.

@pjmonks
Copy link
Contributor

pjmonks commented Jul 18, 2022

We'll need to identify which version of Angular Material to upgrade to. Our npm dependencies are a bit of a mess already, so don't want to drastically upgrade anything unless it's a patch version.

@jamesrwelch
Copy link
Contributor Author

Completely agreed. And we need to work out how to tidy up the existing dependency spaghetti in the near future. We'll talk about the next release in the meeting tomorrow.

@pjmonks pjmonks moved this to Backlog in MDM State Aug 17, 2022
@pjmonks pjmonks moved this from Backlog to Cant Replicate / On Hold in MDM State Aug 17, 2022
@github-project-automation github-project-automation bot moved this from Cant Replicate / On Hold to Merged to Develop / Waiting to release in MDM State Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold Issue has been placed on hold to resolve later
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

2 participants