From bb8d38466e643f848205d385e8e3cfe191edcaa3 Mon Sep 17 00:00:00 2001 From: Elliana May Date: Wed, 15 Jun 2022 03:57:10 +0000 Subject: [PATCH 1/2] test: add xfail test for intervals --- duckdb_engine/tests/test_basic.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/duckdb_engine/tests/test_basic.py b/duckdb_engine/tests/test_basic.py index c76a6a6b..796fe795 100644 --- a/duckdb_engine/tests/test_basic.py +++ b/duckdb_engine/tests/test_basic.py @@ -7,6 +7,7 @@ Column, ForeignKey, Integer, + Interval, MetaData, Sequence, String, @@ -52,6 +53,14 @@ class Owner(Base): # type: ignore ) # type: RelationshipProperty[FakeModel] +class IntervalModel(Base): # type: ignore + __tablename__ = "IntervalModel" + + id = Column(Integer, Sequence("IntervalModel_id_sequence"), primary_key=True) + + field = Column(Interval) + + @fixture def session(engine: Engine) -> Session: return sessionmaker(bind=engine)() @@ -179,3 +188,13 @@ def test_description() -> None: import duckdb duckdb.connect("").description + + +@mark.xfail(reason="support not released", raises=RuntimeError) +def test_intervals(session: Session) -> None: + session.add(IntervalModel(field=timedelta(days=1))) + session.commit() + + owner = session.query(IntervalModel).one() # act + + assert owner.field == timedelta(days=1) From 46379ba9827b539701f45b27279b37f481fb2256 Mon Sep 17 00:00:00 2001 From: Elliana May Date: Wed, 15 Jun 2022 03:58:34 +0000 Subject: [PATCH 2/2] chore: remove non-dud type ignore --- duckdb_engine/tests/test_basic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/duckdb_engine/tests/test_basic.py b/duckdb_engine/tests/test_basic.py index e4228696..ecfc00f6 100644 --- a/duckdb_engine/tests/test_basic.py +++ b/duckdb_engine/tests/test_basic.py @@ -53,7 +53,7 @@ class Owner(Base): ) # type: RelationshipProperty[FakeModel] -class IntervalModel(Base): # type: ignore +class IntervalModel(Base): __tablename__ = "IntervalModel" id = Column(Integer, Sequence("IntervalModel_id_sequence"), primary_key=True)