-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enumerability not a problem #1
Comments
Yes, But the polyfill still fails big time in some cases, so in the end I might end up using As you may notice, getting the names of the properties is one of the biggest challenges of polyfilling |
I don't think there's a real need to support IE8 anymore – according to StatCounter, only 3.7% of users worldwide use it. MDN has a |
Yes, indeed, getting non enumerable properties is basically impossible without the right tools. That's the whole point of the matter. Every web developer would like to ditch IE8 support with great joy, but sadly companies tend to support the widest range of browsers possible, because 3.7% of users with a bad experience with their sites potentially means 3.7% of customers less. In China there's "a lot" (1.55%) of people still using IE6... So I won't forget IE8 support for this polyfill (for now), but I'm ok to support if with a few caveats - not everything can be shimmed, after all. Giving support to most of the features is alright in most cases, and that could be fine. In the end, I decided that I'll swap to Thank you for the cue, it helped me to take a decision on the matter. |
Great! Looking forward :) |
When a property is created using Object.defineProperty and set to not enumerable, it's basically invisible to the polyfill (...) There's no way to prevent this limitation.
And what about
Object.getOwnPropertyNames
? This one returns all (even non-enumerable) properties.Great work though, I'll probably use it in my app :)
The text was updated successfully, but these errors were encountered: