Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Sample XML code to XCTest #1

Merged
merged 9 commits into from
Dec 14, 2018
Merged

Convert Sample XML code to XCTest #1

merged 9 commits into from
Dec 14, 2018

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Nov 19, 2018

Currently most of the tests can be started with custom testing code in Sample XML directory. This prevents easy testing with SwiftPM and generation of code coverage. Tests should be migrated to XCTest to get true test coverage numbers.

Sample XML contents:

  • Breakfast
  • Books
  • Plants
  • RJI
  • CDs
  • Notes

@MaxDesiatov MaxDesiatov changed the title Convert Sample XML code to XCTest Convert Sample XML code to XCTest Nov 19, 2018
@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #1 into master will increase coverage by 8.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   25.99%   34.57%   +8.58%     
==========================================
  Files          12       12              
  Lines        1585     1585              
==========================================
+ Hits          412      548     +136     
+ Misses       1173     1037     -136
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncoder.swift 29.88% <0%> (+6.95%) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 32.93% <0%> (+10.31%) ⬆️
Sources/XMLCoder/Encoder/XMLEncodingStorage.swift 100% <0%> (+12.5%) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 26.22% <0%> (+14.34%) ⬆️
Sources/XMLCoder/XMLStackParser.swift 92.85% <0%> (+17.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdeed2...7426671. Read the comment docs.

* Migrated ‘RJI’ test to proper `XCTest` test case
* Cleanup RJI tests
@MaxDesiatov MaxDesiatov merged commit 0f07759 into master Dec 14, 2018
@MaxDesiatov MaxDesiatov deleted the migrate-tests branch December 14, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants