-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Sample XML
code to XCTest
#1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
Convert Sample XML code to XCTest
Convert Nov 19, 2018
Sample XML
code to XCTest
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 25.99% 34.57% +8.58%
==========================================
Files 12 12
Lines 1585 1585
==========================================
+ Hits 412 548 +136
+ Misses 1173 1037 -136
Continue to review full report at Codecov.
|
This was referenced Nov 20, 2018
MaxDesiatov
force-pushed
the
migrate-tests
branch
3 times, most recently
from
November 24, 2018 14:34
126cbed
to
d34338a
Compare
MaxDesiatov
force-pushed
the
migrate-tests
branch
from
December 14, 2018 09:47
d34338a
to
3a0e6a8
Compare
* Migrated ‘RJI’ test to proper `XCTest` test case * Cleanup RJI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently most of the tests can be started with custom testing code in
Sample XML
directory. This prevents easy testing with SwiftPM and generation of code coverage. Tests should be migrated to XCTest to get true test coverage numbers.Sample XML
contents:Breakfast
Books
Plants
RJI
CDs
Notes