Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark to RJI test suite #20

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Added benchmark to RJI test suite #20

merged 3 commits into from
Dec 18, 2018

Conversation

regexident
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   39.36%   39.36%           
=======================================
  Files          14       14           
  Lines        1443     1443           
=======================================
  Hits          568      568           
  Misses        875      875

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403e6e8...64cbc89. Read the comment docs.

@MaxDesiatov
Copy link
Collaborator

Thank you @regexident, I'll update the sample XML to the new version in master, which is no longer stored in .xml file. I had to change that in #18 as generation of Jazzy docs fails because of cruft accumulated in XMLCoder.xcodeproj. We have to regenerate the project file with swift package generate-xcodeproj. This auto-generation misses files that don't have .swift extensions unfortunately, which means we have missing sample XML file in the test bundle. The sample XML was moved to the .swift file from .xml file.

@MaxDesiatov MaxDesiatov merged commit 863b160 into CoreOffice:master Dec 18, 2018
@regexident regexident deleted the benchmark branch December 18, 2018 16:37
bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this pull request Jul 17, 2019
bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants