Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of explicit internal #29

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Remove use of explicit internal #29

merged 1 commit into from
Dec 21, 2018

Conversation

regexident
Copy link
Contributor

As discussed in #19 (comment).

@regexident regexident changed the title Removed use of explicit internal Remove use of explicit internal Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 82.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   50.55%   50.55%           
=======================================
  Files          28       28           
  Lines        1351     1351           
=======================================
  Hits          683      683           
  Misses        668      668
Impacted Files Coverage Δ
Sources/XMLCoder/Encoder/XMLEncodingStorage.swift 88.88% <ø> (ø) ⬆️
Sources/XMLCoder/Decoder/XMLDecodingStorage.swift 81.81% <ø> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 83.92% <ø> (ø) ⬆️
...rces/XMLCoder/Decoder/DecodingErrorExtension.swift 0% <0%> (ø) ⬆️
...urces/XMLCoder/Encoder/XMLReferencingEncoder.swift 0% <0%> (ø) ⬆️
...rces/XMLCoder/Encoder/EncodingErrorExtension.swift 0% <0%> (ø) ⬆️
...s/XMLCoder/Encoder/XMLKeyedEncodingContainer.swift 42.16% <100%> (ø) ⬆️
...es/XMLCoder/Auxiliaries/ISO8601DateFormatter.swift 100% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLHeader.swift 95.23% <100%> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/XMLElement.swift 90% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b7b20...d09ff32. Read the comment docs.

MaxDesiatov
MaxDesiatov previously approved these changes Dec 21, 2018
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@MaxDesiatov
Copy link
Collaborator

@regexident, looks like a few conflicts appeared after merging your other PR, hope these can be resolved easily

@regexident
Copy link
Contributor Author

Should be ready to merge now. 🙂

@MaxDesiatov
Copy link
Collaborator

@hodovani this can be reviewed and/or merged as usual. Thanks!

MaxDesiatov
MaxDesiatov previously approved these changes Dec 21, 2018
@MaxDesiatov MaxDesiatov merged commit a6a7233 into CoreOffice:master Dec 21, 2018
@regexident regexident deleted the fix/internal branch December 21, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants