Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftLint and fix linter errors #35

Merged
merged 7 commits into from
Jan 18, 2019
Merged

Add SwiftLint and fix linter errors #35

merged 7 commits into from
Jan 18, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Dec 22, 2018

Cleanup type names, fix line length, add .swiftlint.yml and swiftlint run to .travis.yml.

Resolves #24

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #35 into master will decrease coverage by 1.31%.
The diff coverage is 66.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   76.93%   75.62%   -1.32%     
==========================================
  Files          31       31              
  Lines        1396     1489      +93     
==========================================
+ Hits         1074     1126      +52     
- Misses        322      363      +41
Impacted Files Coverage Δ
Sources/XMLCoder/Auxiliaries/Box/DateBox.swift 95.74% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/DataBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/SharedBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/DecimalBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/UIntBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/XMLKey.swift 100% <ø> (ø) ⬆️
Sources/XMLCoder/Auxiliaries/Box/NullBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/FloatBox.swift 100% <ø> (ø)
Sources/XMLCoder/Auxiliaries/Box/URLBox.swift 100% <ø> (ø)
Sources/XMLCoder/Encoder/XMLEncodingStorage.swift 82.6% <ø> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7b0d6...f731bec. Read the comment docs.

@MaxDesiatov MaxDesiatov assigned hodovani and unassigned MaxDesiatov Jan 18, 2019
@MaxDesiatov MaxDesiatov merged commit 401de6a into master Jan 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the swiftlint branch January 18, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SwiftLint to CI runs
2 participants