-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyed/unkeyed boxes as structs #36
Keyed/unkeyed boxes as structs #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 74.51% 74.66% +0.14%
==========================================
Files 30 31 +1
Lines 1440 1551 +111
==========================================
+ Hits 1073 1158 +85
- Misses 367 393 +26
Continue to review full report at Codecov.
|
Upon further inspection (ie. running #34 repeatedly) the performance seems to have remained stable. I'd thus propose to merge this PR as it unifies the representation of |
Any chance to have this merged, @MaxDesiatov/@hodovani? |
…ss-to-struct # Conflicts: # Sources/XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift # XMLCoder.xcodeproj/project.pbxproj
@regexident I've fixed the conflicts and there's still a |
Thanks @MaxDesiatov! |
Not sure yet, if this will actually lead to an improvement of performance.
Running the benchmark from #34 should give a better image of the situation.
🏗Consider this an experimental WIP.