Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding of arrays with optional elements #48

Merged
merged 3 commits into from
Dec 30, 2018
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Dec 30, 2018

Also move protocols for tricks with metatypes to new Metatypes file.

Fix formatting of long lines in related files.

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #48 into master will increase coverage by 0.23%.
The diff coverage is 38.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   56.01%   56.24%   +0.23%     
==========================================
  Files          29       30       +1     
  Lines        1414     1433      +19     
==========================================
+ Hits          792      806      +14     
- Misses        622      627       +5
Impacted Files Coverage Δ
Sources/XMLCoder/Decoder/XMLDecoder.swift 38.64% <ø> (ø) ⬆️
...XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift 9.16% <0%> (-1.01%) ⬇️
Sources/XMLCoder/Auxiliaries/Metatypes.swift 100% <100%> (ø)
Sources/XMLCoder/Auxiliaries/XMLStackParser.swift 91.78% <100%> (ø) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 45.39% <35.29%> (+2.53%) ⬆️
Sources/XMLCoder/Auxiliaries/XMLElement.swift 94.4% <83.33%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4954c9...5a27357. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit d4e7673 into master Dec 30, 2018
@delete-merged-branch delete-merged-branch bot deleted the unkeyed-nil branch December 30, 2018 16:56
bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this pull request Sep 30, 2019
Transform precondition to where clause in switch statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant