Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single array element example to tests #66

Merged
merged 2 commits into from
Jan 18, 2019
Merged

Add single array element example to tests #66

merged 2 commits into from
Jan 18, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

Resolves #65

@codecov
Copy link

codecov bot commented Jan 18, 2019 •
edited
Loading

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files          31       31           
  Lines        1396     1396           
=======================================
  Hits         1074     1074           
  Misses        322      322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7583691...f662dbe. Read the comment docs.

@MaxDesiatov MaxDesiatov mentioned this pull request Jan 18, 2019
Closed
hodovani
hodovani approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@hodovani hodovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test @MaxDesiatov, very warm tag names.

@MaxDesiatov MaxDesiatov merged commit 2f7b0d6 into master Jan 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the single-child branch January 18, 2019 11:13
@stonedauwg
Copy link

You like those @hodovani? He got those from my issue 😋

@stonedauwg
Copy link

@MaxDesiatov I just tried master and can confirm this is fixed. Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @stonedauwg @hodovani