From ca6469c6c71aacc2cb2fe436fc076cb6fe2fcd85 Mon Sep 17 00:00:00 2001 From: envoza Date: Mon, 30 Aug 2021 13:44:06 +0100 Subject: [PATCH 1/2] episode_count is not returned for single episode --- Common/Models/People/TraktCastMember.swift | 2 +- Common/Models/People/TraktCrewMember.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Common/Models/People/TraktCastMember.swift b/Common/Models/People/TraktCastMember.swift index 376962f..c5a0e7f 100644 --- a/Common/Models/People/TraktCastMember.swift +++ b/Common/Models/People/TraktCastMember.swift @@ -13,7 +13,7 @@ public struct TVCastMember: Codable, Hashable { public let characters: [String] @available(*, deprecated, renamed: "characters") public let character: String - public let episodeCount: Int + public let episodeCount: Int? public let person: Person enum CodingKeys: String, CodingKey { diff --git a/Common/Models/People/TraktCrewMember.swift b/Common/Models/People/TraktCrewMember.swift index 46e2874..67c4ee7 100644 --- a/Common/Models/People/TraktCrewMember.swift +++ b/Common/Models/People/TraktCrewMember.swift @@ -13,7 +13,7 @@ public struct TVCrewMember: Codable, Hashable { public let jobs: [String] @available(*, deprecated, renamed: "jobs") public let job: String - public let episodeCount: Int + public let episodeCount: Int? public let person: Person enum CodingKeys: String, CodingKey { From 4c0c625458e1473c9a8d247952a33c57b645440e Mon Sep 17 00:00:00 2001 From: envoza Date: Mon, 30 Aug 2021 13:45:06 +0100 Subject: [PATCH 2/2] getPeopleInEpisode was reporting false success --- TraktKitTests/EpisodeTests.swift | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/TraktKitTests/EpisodeTests.swift b/TraktKitTests/EpisodeTests.swift index 5acb554..9b683e0 100644 --- a/TraktKitTests/EpisodeTests.swift +++ b/TraktKitTests/EpisodeTests.swift @@ -230,14 +230,17 @@ class EpisodeTests: XCTestCase { traktManager.getPeopleInEpisode(showID: "game-of-thrones", season: 1, episode: 1) { result in if case .success(let castAndCrew) = result { XCTAssertNotNil(castAndCrew.cast) - XCTAssertNotNil(castAndCrew.producers) + XCTAssertNotNil(castAndCrew.writers) XCTAssertEqual(castAndCrew.cast!.count, 20) - XCTAssertEqual(castAndCrew.producers!.count, 14) + XCTAssertEqual(castAndCrew.writers!.count, 2) guard let actor = castAndCrew.cast?.first else { XCTFail("Cast is empty"); return } XCTAssertEqual(actor.person.name, "Emilia Clarke") XCTAssertEqual(actor.characters, ["Daenerys Targaryen"]) } + else { + XCTFail("Invalid result") + } expectation.fulfill() } let result = XCTWaiter().wait(for: [expectation], timeout: 5)