From 1fbace5a0c58e787b7f503e375288419f1462cfa Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Tue, 6 Mar 2018 19:29:21 +0530 Subject: [PATCH] test: address nits and rename the corresponding fixture Refs: https://github.com/nodejs/node/issues/19105 PR-URL: https://github.com/nodejs/node/pull/19161 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil --- .../{test-regress-GH-4015.js => test-fs-stat-sync-overflow.js} | 0 test/sequential/test-fs-stat-sync-overflow.js | 2 +- test/sequential/test-net-response-size.js | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename test/fixtures/{test-regress-GH-4015.js => test-fs-stat-sync-overflow.js} (100%) diff --git a/test/fixtures/test-regress-GH-4015.js b/test/fixtures/test-fs-stat-sync-overflow.js similarity index 100% rename from test/fixtures/test-regress-GH-4015.js rename to test/fixtures/test-fs-stat-sync-overflow.js diff --git a/test/sequential/test-fs-stat-sync-overflow.js b/test/sequential/test-fs-stat-sync-overflow.js index c770b6b1560785..9c9109989a19c3 100644 --- a/test/sequential/test-fs-stat-sync-overflow.js +++ b/test/sequential/test-fs-stat-sync-overflow.js @@ -34,7 +34,7 @@ const assert = require('assert'); const { exec } = require('child_process'); const cmd = - `"${process.execPath}" "${fixturesDir}/test-regress-GH-4015.js"`; + `"${process.execPath}" "${fixturesDir}/test-fs-stat-sync-overflow.js"`; exec(cmd, function(err, stdout, stderr) { assert(/RangeError: Maximum call stack size exceeded/.test(stderr)); diff --git a/test/sequential/test-net-response-size.js b/test/sequential/test-net-response-size.js index e6be7fa7273362..c5d7e9b600e05d 100644 --- a/test/sequential/test-net-response-size.js +++ b/test/sequential/test-net-response-size.js @@ -23,7 +23,7 @@ const common = require('../common'); // Make sure the net module's server doesn't throw an error when handling -// responses that are either too long or too small (especially on windows) +// responses that are either too long or too small (especially on Windows) // https://github.com/nodejs/node-v0.x-archive/issues/1697 const net = require('net');