Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rejecting use of private fields #4373

Closed
gilles-peskine-arm opened this issue Apr 19, 2021 · 4 comments
Closed

Implement rejecting use of private fields #4373

gilles-peskine-arm opened this issue Apr 19, 2021 · 4 comments
Labels
enhancement needs-preceding-pr Requires another PR to be merged first size-m Estimated task size: medium (~1w)

Comments

@gilles-peskine-arm
Copy link
Contributor

Implement the strategy for rejecting the use of private fields investigated in #4372 to the private fields of the classic API in 3.0 documented in #4371, as well as to PSA API private fields in both 2.2x and 3.0.

@mpg
Copy link
Contributor

mpg commented Apr 27, 2021

Note: we have about a hundred structures in public headers. We probably don't need to do all of them at once, though.

@mpg mpg added the size-m Estimated task size: medium (~1w) label Apr 27, 2021
@gilles-peskine-arm
Copy link
Contributor Author

We probably don't need to do all of them at once, though.

It'll be easier to do them all at once with a global search-and-replace.

@mpg
Copy link
Contributor

mpg commented Apr 27, 2021

I'm probably missing something, but I was thinking it would need to be done struct by struct.

@gilles-peskine-arm
Copy link
Contributor Author

This was done in #4511

@bensze01 bensze01 modified the milestone: Mbed TLS 4.0 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-preceding-pr Requires another PR to be merged first size-m Estimated task size: medium (~1w)
Projects
None yet
Development

No branches or pull requests

3 participants