-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
component_test_full_no_bignum doesn't actually disable bignum #9190
Comments
I've fixed that in #9185. |
It is especially redundant with |
Thanks Manuel. I am removing it in #9185. |
Looks like this was fixed by #9185 - I'm not seeing |
I'm reopening because this is moot in |
As of #9172,
component_test_full_no_bignum
actually enables all crypto because it hasMBEDTLS_PSA_CRYPTO_CONFIG
enabled. For example,PSA_WANT_KEY_TYPE_RSA_PUBLIC_KEY
is enabled by default, soMBEDTLS_RSA_C
andMBEDTLS_BIGNUM_C
are auto-enabled to implement that.The goal of this task is:
component_test_full_no_bignum
to do what it actually claims. For 3.6, it's enough to disableMBEDTLS_PSA_CRYPTO_CONFIG
. For development leading to 4.0, we need to disable all asymmetric crypto through bothMBEDTLS_xxx
andPSA_WANT_xxx
.component_test_full_no_bignum
, check thatmbedtls_bignum_xxx
functions aren't getting included in the build.Alternative goal: remove
component_test_full_no_bignum
because it's redundant withtest-ref-configs
onconfigs/config-symmetric-only.h
?The text was updated successfully, but these errors were encountered: