Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARIA_ALT header and self-test and CAMELLIA_ALT self-test #4553

Merged
merged 4 commits into from
May 25, 2021
Merged

Fix ARIA_ALT header and self-test and CAMELLIA_ALT self-test #4553

merged 4 commits into from
May 25, 2021

Conversation

gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented May 25, 2021 •
edited
Loading

Fix ARMmbed/mbed-os#14694

Backports: 2.x (#4557), 2.16 (#4558)

@gilles-peskine-arm
Fix misplaced extern "C" affecting MBEDTLS_ARIA_ALT
59392b0 
Reported via Mbed OS:
ARMmbed/mbed-os#14694

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
ARIA: add missing context init/free
be89fea 
This fixes the self-test with alternative implementations.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm
CAMELLIA: add missing context init/free
c537aa8 
This fixes the self-test with alternative implementations.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, needs-backports Backports are missing or are pending review and approval. component-crypto Crypto primitives and low-level interfaces needs-reviewer This PR needs someone to pick it up for review labels May 25, 2021
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request May 25, 2021
Closed
@gilles-peskine-arm
Changelog entry for the ARIA_ALT and CAMELLIA_ALT fixes
0e1f05d 
Fix ARMmbed/mbed-os#14694

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
davidhorstmann-arm
davidhorstmann-arm approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tom-daubney-arm tom-daubney-arm self-requested a review May 25, 2021 16:23
tom-daubney-arm
tom-daubney-arm approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels May 25, 2021
This was referenced May 25, 2021
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-backports Backports are missing or are pending review and approval. labels May 25, 2021
@gilles-peskine-arm gilles-peskine-arm merged commit 8a5304d into Mbed-TLS:development May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues when compiling and executing ARIA for hardware accelerated crypto
3 participants
@gilles-peskine-arm @davidhorstmann-arm @tom-daubney-arm