Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ChangeLog entry correcting the record on #4044 #4893

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

davidhorstmann-arm
Copy link
Contributor

NOTE: Do not merge this PR before #4044 is merged! (Lest we have to do this a second time.)
Partial fix for #4870.

A ChangeLog entry was created for #4044 by mistake in the 2.16.10 release, without #4044 having been merged. This PR creates a new ChangeLog entry explaining that the previous ChangeLog entry was incorrect, but that the fix has now been merged.

Status

READY

Requires Backporting

NO

Migrations

If there is any API change, what's the incentive and logic for it.

NO

Todos

  • Tests
  • Documentation
  • Changelog updated
  • Backported

The change made by PR Mbed-TLS#4044 was previously advertised in the
2.16.10 ChangeLog, however Mbed-TLS#4044 had not yet been merged.
Create a new entry for Mbed-TLS#4044, with a note that the previous
entry was in error.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review single-reviewer This PR qualifies for having only one reviewer labels Aug 26, 2021
@yanesca yanesca self-requested a review August 26, 2021 14:06
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yanesca yanesca added needs-preceding-pr Requires another PR to be merged first and removed needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Aug 26, 2021
@yanesca yanesca merged commit 5e5ca8e into Mbed-TLS:mbedtls-2.16 Aug 26, 2021
@davidhorstmann-arm davidhorstmann-arm deleted the 4044-chglog-take2 branch August 26, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic constraints extension fix in x509 code was not ported to 2.16 as believed.
2 participants