Backport 2.x: Fix psa_generate_key(): return PSA_ERROR_INVALID_ARGUMENT for public key #5037 #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
mprse
added
needs-review
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
There was a problem hiding this comment.
This is a straight backport of #5037. It looks good to me except that one thing needs to be different from the original: in 2.x, the generated source files are checked into git, so you need to run tests/scripts/check-generated-files.sh -u and commit the result. (This should resolve most of the CI failures.)
Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>
|
Re-generated and committed |
gilles-peskine-arm
approved these changes
Oct 12, 2021
gilles-peskine-arm
added
needs-ci
gilles-peskine-arm
added
approved
bensze01
added a commit
to bensze01/psa-arch-tests
that referenced
this pull request
Nov 8, 2021
Test psa_generate_key with RSA 2048 Public key Changed the error code from PSA_ERROR_NOT_SUPPORTED to PSA_ERROR_INVALID_ARGUMENT as in the documentation of psa_generate_key() returned values: "PSA_ERROR_INVALID_ARGUMENT The key type is an asymmetric public key type." See: Mbed-TLS/mbedtls#4551 Mbed-TLS/mbedtls#5037 Mbed-TLS/mbedtls#5038 Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
added a commit
to bensze01/psa-arch-tests
that referenced
this pull request
Nov 10, 2021
Test psa_generate_key with RSA 2048 Public key Changed the error code from PSA_ERROR_NOT_SUPPORTED to PSA_ERROR_INVALID_ARGUMENT as in the documentation of psa_generate_key() returned values: "PSA_ERROR_INVALID_ARGUMENT The key type is an asymmetric public key type." See: Mbed-TLS/mbedtls#4551 Mbed-TLS/mbedtls#5037 Mbed-TLS/mbedtls#5038 Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
added a commit
to bensze01/psa-arch-tests
that referenced
this pull request
Jan 12, 2022
Test psa_generate_key with RSA 2048 Public key Changed the error code from PSA_ERROR_NOT_SUPPORTED to PSA_ERROR_INVALID_ARGUMENT as in the documentation of psa_generate_key() returned values: "PSA_ERROR_INVALID_ARGUMENT The key type is an asymmetric public key type." See: Mbed-TLS/mbedtls#4551 Mbed-TLS/mbedtls#5037 Mbed-TLS/mbedtls#5038 Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport for PR #5037.
Status
READY