Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Usability Issue - Nodes hidden from search providers cannot be copied #30

Open
McManning opened this issue Aug 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@McManning
Copy link
Owner

There's a conflict between the rules of the CopyPasteGraph and the search providers. If I hide nodes from DefaultSearchProvider, e.g. by tagging them as something not in a Graph's [IncludeTags], the CopyPasteGraph will also exclude these nodes when reapplying them onto the graph. So all copy/paste/duplicate operations don't work.

I'd like to be able to denote that a node is hidden from the default search provider but can still be used on a graph, preferably by not just giving it a tag that isn't in [IncludeTags].

@McManning McManning added the bug Something isn't working label Aug 30, 2020
@McManning
Copy link
Owner Author

Easiest solution would be that any node copied from a graph can be pasted back onto that same graph. This does create a conflict with [Node(deletable = false)] though - since we'd no longer be checking tags for nodes on the same graph. Maybe deletable becomes something more restrictive, like readOnly?

@neoneper
Copy link
Contributor

I bumped into that bug too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants