-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to update documentation and comments here to reflect that parent_codes
must be formatted in a specific way.
#36
Comments
I don't think that's quite right, as parent_codes should, and will, contain non-OMOP concepts to handle dataset specific ontology structures.
|
Can you suggest some updated language @EthanSteinberg? I want to make sure it is accurately described. |
What's wrong with the language I posted above in my original reply? |
I apologize -- I didn't realize you had modified the quoted text, I thought you were just commenting on that block specifically in your reply. That text looks great. Thank you! |
meds/src/meds/schema.py
Line 134 in 5f87c2f
@EthanSteinberg is the following language accurate for their constraints?
parent_codes
must be a list of strings, each string being a parent code in the OMOP concept space corresponding to this code. Here, a "parent" means that this code must be a realization of either the referenced OMOP concept or a more specific example of said concept. OMOP concepts are referenced in these strings via the format"$VOCABULARY_NAME/$CONCEPT_NAME"
. For example:"ICD9CM/487.0"
The text was updated successfully, but these errors were encountered: