Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Gerrit Review Web (or Side) PAnel is not complete #39

Open
philippecaulier opened this issue Sep 16, 2016 · 1 comment
Open

The Gerrit Review Web (or Side) PAnel is not complete #39

philippecaulier opened this issue Sep 16, 2016 · 1 comment

Comments

@philippecaulier
Copy link

Hello,

I'm using the latest version of Jira-gerrit-plugin 3.1 and use Gerrit to create review code. On Jira side the panel (Gerrit Review side Panel) doesn't contain the MERGED reviews even if I select all reviews in the top right corner menu of Gerrit panel.
I enable the other panel (GerritReviewTabPanel) and all the reviews are listed in this Tab.

It's very confusing for development team not to have all the MERGED reviews in the gerrit panel.

Do I not setting correctly my plugin or it is a bug ?

Thanks in advance for your support.

Philippe Caulier
AIRBUS Defence and Space company

@jhansche
Copy link

jhansche commented Feb 2, 2017

The side panel and the tab panels were the first views that were created, and they did not have configurable filters like the one you're referring to. They were also written at a time where Gerrit did not yet have the secondary Lucene index, which meant that there were performance concerns, where listing already-merged reviews was incredibly slow, and would only work if you were using an already indexed search predicate (i.e., tr:%s, which uses the tracking_ids index)

As of recent versions of Gerrit, that index is no longer a performance concern, which is why the Web Panel view was created to allow showing open-only reviews, as well as closed reviews. I just never went back to update the other views like the one you're talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants