Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SRCS on SC #6009

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Allow SRCS on SC #6009

merged 1 commit into from
Sep 17, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Sep 15, 2024

Allows mounting of Smart Robotic Control Systems on SmallCraft.
MegaMek/megameklab#1559

@HammerGS IO p215 and p134 are contradictory but at least it seems clear that SC should be allowed to mount it and improve it. WS are unclear and the improved version is even more unclear (SV allowed?).

@SJuliez SJuliez requested a review from HammerGS September 15, 2024 21:02
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (f8cac64) to head (0cace95).
Report is 46 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6009      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13960    13958       -2     
============================================
  Files          2576     2576              
  Lines        267395   267398       +3     
  Branches      47803    47803              
============================================
  Hits          77744    77744              
- Misses       185750   185755       +5     
+ Partials       3901     3899       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

Allows mounting of Smart Robotic Control Systems on SmallCraft. MegaMek/megameklab#1559

@HammerGS IO p215 and p134 are contradictory but at least it seems clear that SC should be allowed to mount it and improve it. WS are unclear and the improved version is even more unclear (SV allowed?).

Yeah, SC would be allows. WS are limited to SDS (CASPAR) DRONE CONTROL SYSTEM (SDS-DCS)

SV's would be allowed as well.

@IllianiCBT IllianiCBT merged commit 472c913 into MegaMek:master Sep 17, 2024
5 checks passed
@SJuliez SJuliez deleted the SRCS-on-sc branch October 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants