Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost for cargo bays on vehicles is incorrect #763

Closed
assaultdoor opened this issue Sep 18, 2020 · 0 comments · Fixed by MegaMek/megamek#2312
Closed

Cost for cargo bays on vehicles is incorrect #763

assaultdoor opened this issue Sep 18, 2020 · 0 comments · Fixed by MegaMek/megamek#2312
Labels
Milestone

Comments

@assaultdoor
Copy link

assaultdoor commented Sep 18, 2020

I've noticed the following issues with cargo bay costs for combat and support vehicles using MML 0.47.9 on OS X:

  1. All cargo bays on combat vehicles allocated through the Transport section of the Structure/Armor tab are free. Per TM p. 293, only basic cargo, cargo containers, and infantry compartments should be free.
  2. Liquid cargo on support vehicles costs 100 c-bills + 100 c-bills/ton when it should cost just 100 c-bills/ton
  3. Refrigerated cargo on support vehicles costs 200 c-bills + 200 c-bills/ton when it should just cost 200 c-bills/ton
  4. Insulated cargo costs 250 + 250/ton when it should just be 250/ton

Updated because I forgot that cargo bay doors are expensive.

Update 2: I think this might be a floating point issue. When I create a vehicle with one ton of liquid cargo (a transport capacity of 0.91 tons), the file saves with the line "liquidcargobay:0.9100000000000001:0:1". If I manually edit the file to trim that down to 0.91 tons and then re-load the vehicle, the bay has the correct cost.

@neoancient neoancient added this to the Stable 0.48 milestone Oct 3, 2020
@neoancient neoancient changed the title Cost for cargo bays on vehicles is incorect Cost for cargo bays on vehicles is incorrect Oct 6, 2020
@neoancient neoancient added the Bug label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants