Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double heatsinks incorrectly switching between Clan and IS versions #842

Closed
alexbib opened this issue Dec 8, 2020 · 3 comments · Fixed by MegaMek/megamek#2502
Closed

Comments

@alexbib
Copy link

alexbib commented Dec 8, 2020

On mixtech Mechs using Clan double heatsinks, some of them are sometimes transformed to IS double heatsinks (3 crits instead of 2). This usually happens on unassigning them from a location, or when changing engine size (and thus changing the number of heatsinks that do not occupy crit space).

I'm on version 0.47.14 on Windows 10 64-bit.

@neoancient
Copy link
Member

I worked with this for a while but never saw the problem. Can you give me specific steps to reproduce it?

@alexbib
Copy link
Author

alexbib commented Dec 9, 2020

Quickest way for me to reproduce it is to load a saved mixed IS mech with clan double HS (for instance the one I attached) and manually pull off a HS from its crit or reduce the mech's walking MP by 1.
HSbug.zip

Right now it seems to only do it after loading a mech from file, and not during the first build (though I could have sworn it did it to me without loading a few days ago, but maybe I'm misremembering)

@neoancient
Copy link
Member

That would be why I couldn't reproduce it. I think I know what the problem might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants