Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show packages in the dry run that need publishing #58

Closed
mcmire opened this issue Oct 24, 2023 · 0 comments · Fixed by #90
Closed

Only show packages in the dry run that need publishing #58

mcmire opened this issue Oct 24, 2023 · 0 comments · Fixed by #90
Assignees
@rickycodes
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Oct 24, 2023 •
edited
Loading

When reviewing a release for the core monorepo, it can be seriously confusing if all packages show up in the dry run output. It misleads the reviewer into thinking that all packages will be released, when only a subset may be released.

Also see #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickycodes rickycodes

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show packages in the dry run that need publishing MetaMask/action-npm-publish
2 participants
@mcmire @rickycodes