From 3ed5af713e3a82d3d7e29c4f34ed9b992806bdf3 Mon Sep 17 00:00:00 2001 From: legobeat <109787230+legobeat@users.noreply.github.com> Date: Mon, 2 Oct 2023 17:53:58 +0000 Subject: [PATCH] fix(gas-fee-controller): add missing @metamask/polling-controller (#1748) ## Explanation Adds missing dependency introduced in #1673 ## References - Follow-up to: #1673 ## Changelog ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex --- constraints.pro | 5 +++-- packages/gas-fee-controller/package.json | 1 + yarn.lock | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/constraints.pro b/constraints.pro index a9d9031308d..f79e0a5e4c7 100644 --- a/constraints.pro +++ b/constraints.pro @@ -298,14 +298,15 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :- workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType), DependencyType == 'devDependencies'. -% If a controller dependency (other than `base-controller` and -% `eth-keyring-controller`) is listed under "dependencies", it should also be +% If a controller dependency (other than `base-controller`, `eth-keyring-controller` and +% `polling-controller`) is listed under "dependencies", it should also be % listed under "peerDependencies". Each controller is a singleton, so we need % to ensure the versions used match expectations. gen_enforced_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'peerDependencies') :- workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'dependencies'), DependencyIdent \= '@metamask/base-controller', DependencyIdent \= '@metamask/eth-keyring-controller', + DependencyIdent \= '@metamask/polling-controller', is_controller(DependencyIdent). % All packages must specify a minimum Node version of 16. diff --git a/packages/gas-fee-controller/package.json b/packages/gas-fee-controller/package.json index 17ffbb8df74..10f08f72df6 100644 --- a/packages/gas-fee-controller/package.json +++ b/packages/gas-fee-controller/package.json @@ -33,6 +33,7 @@ "@metamask/controller-utils": "^5.0.1", "@metamask/eth-query": "^3.0.1", "@metamask/network-controller": "^13.0.1", + "@metamask/polling-controller": "^0.0.0", "@metamask/utils": "^8.1.0", "@types/uuid": "^8.3.0", "ethereumjs-util": "^7.0.10", diff --git a/yarn.lock b/yarn.lock index 5110baa876c..65916e5aa66 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1807,6 +1807,7 @@ __metadata: "@metamask/controller-utils": ^5.0.1 "@metamask/eth-query": ^3.0.1 "@metamask/network-controller": ^13.0.1 + "@metamask/polling-controller": ^0.0.0 "@metamask/utils": ^8.1.0 "@types/jest": ^27.4.1 "@types/jest-when": ^2.7.3 @@ -2120,7 +2121,7 @@ __metadata: languageName: unknown linkType: soft -"@metamask/polling-controller@workspace:packages/polling-controller": +"@metamask/polling-controller@^0.0.0, @metamask/polling-controller@workspace:packages/polling-controller": version: 0.0.0-use.local resolution: "@metamask/polling-controller@workspace:packages/polling-controller" dependencies: