Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@metamask/json-rpc-{engine,middleware-stream} - Create tags for release commits that were untagged in the pre-migration repo #2002

Closed
MajorLift opened this issue Nov 7, 2023 · 3 comments
Assignees

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Nov 7, 2023

Explanation

While migrating @metamask/json-rpc-engine and @metamask/json-rpc-middleware-stream into the core repo, some earlier release commits that were untagged in the original repo were skipped by the tag porting script. These need to be tagged manually.

References

@MajorLift
Copy link
Contributor Author

MajorLift commented Nov 8, 2023

  • Successfully added missing json-rpc-engine tags to core.

  • Tags are sorted by release commit timestamp if created with the git tag <tag-name> [commit-hash] command.

  • Newly added json-rpc-engine tags:

To https://github.com/MetaMask/core.git
 * [new tag]           json-rpc-engine@3.0.1 -> json-rpc-engine@3.0.1
 * [new tag]           json-rpc-engine@3.1.0 -> json-rpc-engine@3.1.0
 * [new tag]           json-rpc-engine@3.1.1 -> json-rpc-engine@3.1.1
 * [new tag]           json-rpc-engine@3.3.0 -> json-rpc-engine@3.3.0
 * [new tag]           json-rpc-engine@3.3.1 -> json-rpc-engine@3.3.1
 * [new tag]           json-rpc-engine@3.4.0 -> json-rpc-engine@3.4.0
 * [new tag]           json-rpc-engine@3.5.0 -> json-rpc-engine@3.5.0
 * [new tag]           json-rpc-engine@3.6.0 -> json-rpc-engine@3.6.0
 * [new tag]           json-rpc-engine@3.6.1 -> json-rpc-engine@3.6.1
 * [new tag]           json-rpc-engine@3.6.2 -> json-rpc-engine@3.6.2
 * [new tag]           json-rpc-engine@3.6.3 -> json-rpc-engine@3.6.3
 * [new tag]           json-rpc-engine@3.7.0 -> json-rpc-engine@3.7.0
 * [new tag]           json-rpc-engine@3.7.1 -> json-rpc-engine@3.7.1
 * [new tag]           json-rpc-engine@3.7.2 -> json-rpc-engine@3.7.2
 * [new tag]           json-rpc-engine@3.7.3 -> json-rpc-engine@3.7.3
 * [new tag]           json-rpc-engine@3.7.4 -> json-rpc-engine@3.7.4
 * [new tag]           json-rpc-engine@3.8.0 -> json-rpc-engine@3.8.0
 * [new tag]           json-rpc-engine@5.1.7 -> json-rpc-engine@5.1.7
  • All json-rpc-engine tags in core:
❯ git ls-remote --tags upstream | grep 'json-rpc-engine'
22ff65e0f76710188b527bd5d3f81dd2103c5514        refs/tags/@metamask/json-rpc-engine@7.0.0
7639432339e60767a8239d681911375833bc3839        refs/tags/@metamask/json-rpc-engine@7.1.0
23aa8d9e59d9275c0725cb0264057e082034dae9        refs/tags/@metamask/json-rpc-engine@7.1.1
67c7fee5141f6c0bb2f459c1cb3062c02bbf6a15        refs/tags/@metamask/json-rpc-engine@7.2.0
7be37122c1681dd4c889eabd8bcd6aedf8686f19        refs/tags/json-rpc-engine@2.2.1
d3f5230394d0831affb6ef87c09c68a2ceca2d25        refs/tags/json-rpc-engine@2.2.2
93b6ae3f144ef73e3ee48d19e18b4c8333520b21        refs/tags/json-rpc-engine@2.2.3
0ec3c607e05c4ba44a7b85e64c3a4d9645818211        refs/tags/json-rpc-engine@3.0.0
73136e5b7cc553a75dc239602fdf33a4ebd7db61        refs/tags/json-rpc-engine@3.0.1
fd8892cdd68b613b89fec8d2e0cc4f016f6737fa        refs/tags/json-rpc-engine@3.1.0
ad3783db7b6ec4e74f5e14e5d38ea8fa61413201        refs/tags/json-rpc-engine@3.1.1
863b89461a6a6e4fcabe8de488f007c99190cee1        refs/tags/json-rpc-engine@3.3.0
534619550a293ac7f47333fc0477e9d95a0510dd        refs/tags/json-rpc-engine@3.3.1
13229bdd7b35f4c40f8d8f1d3a32e5c177178088        refs/tags/json-rpc-engine@3.4.0
6e0637c1bb25a81e32836c2c52fac6e2708736b0        refs/tags/json-rpc-engine@3.5.0
d4b95b4d3c7e446a7190626f68481b781fa45056        refs/tags/json-rpc-engine@3.6.0
f6bfc66e1327c52ac69153f75d395d7d3f67aa36        refs/tags/json-rpc-engine@3.6.1
8f66f81b825e921ab1148123c084480356dbda66        refs/tags/json-rpc-engine@3.6.2
92ed8e1fd1e142e76f29ab4aac03ff34bdb133fb        refs/tags/json-rpc-engine@3.6.3
fffa361aad4b457f4b363bb732ce1ab947a4d4ef        refs/tags/json-rpc-engine@3.7.0
c275d3b0d2f2ac34e2a86825b63228c8bc73e66d        refs/tags/json-rpc-engine@3.7.1
5012017697b37272b860590bc19fed93640fc2cb        refs/tags/json-rpc-engine@3.7.2
cadc57dbe0222c4ffbdd8cf13cf8f31bfb4b0448        refs/tags/json-rpc-engine@3.7.3
887790c3db85b96fe3655852f2e7205402d2b462        refs/tags/json-rpc-engine@3.7.4
81e69bfac9fb46ad7e26d3cedb9088a60374dbfe        refs/tags/json-rpc-engine@3.8.0
259c94cce92ac5fe878ea5c7b0185091e8c325b2        refs/tags/json-rpc-engine@4.0.0
a172f42954e9ade0879a089bc2549e5b199882f8        refs/tags/json-rpc-engine@5.0.0
2115e15a6823fa233b53f400d1a3f59a69c7fa92        refs/tags/json-rpc-engine@5.1.0
bfa18259bac838353b6d1cf585b792e2d72e1db3        refs/tags/json-rpc-engine@5.1.1
e47ec51cfcc63260092b1f85797f686f4e8a7c8a        refs/tags/json-rpc-engine@5.1.2
d3deed084d4afddc0f032013bbc78d9b2fb2f2ad        refs/tags/json-rpc-engine@5.1.3
37d5229265a6eadb46d7f2dc977aff4e6efcd7ee        refs/tags/json-rpc-engine@5.1.4
ed36940c1f4210927cb30bf05f9acd2ae2c617bf        refs/tags/json-rpc-engine@5.1.5
eb654458fa1cb610bfdf1cc86af356bf7c76ed8a        refs/tags/json-rpc-engine@5.1.6
a21ebf1c12d529d67da48dd1fbc3fac4e5f7e85d        refs/tags/json-rpc-engine@5.1.7
e28bea05d9fbe37f5d5dd86da28b32079b9d9a7b        refs/tags/json-rpc-engine@5.1.8
0a71be92574f76daeb194d14d9ad62ef0fe1cd19        refs/tags/json-rpc-engine@5.2.0
b647309709ddda0850f54a420a3173cf6217de71        refs/tags/json-rpc-engine@5.3.0
2d6cc118d50ed3e67931d09778906a5a8e200b32        refs/tags/json-rpc-engine@5.4.0
9646dc2664c42cec074f4dfcbd70251c6ca3d195        refs/tags/json-rpc-engine@6.0.0
670d8dd774875927912952576e4c5f0596b4ff3d        refs/tags/json-rpc-engine@6.1.0

@MajorLift MajorLift reopened this Nov 8, 2023
@MajorLift MajorLift changed the title @metamask/json-rpc-engine - Create tags for release commits that were untagged in the pre-migration repo @metamask/json-rpc-{engine,middleware-stream} - Create tags for release commits that were untagged in the pre-migration repo Nov 9, 2023
@MajorLift
Copy link
Contributor Author

MajorLift commented Nov 9, 2023

  • Newly added json-rpc-middleware-stream tags:
To https://github.com/MetaMask/core
 * [new tag]           json-rpc-middleware-stream@1.0.0 -> json-rpc-middleware-stream@1.0.0
 * [new tag]           json-rpc-middleware-stream@1.0.1 -> json-rpc-middleware-stream@1.0.1
 * [new tag]           json-rpc-middleware-stream@2.0.0 -> json-rpc-middleware-stream@2.0.0
 * [new tag]           json-rpc-middleware-stream@2.1.0 -> json-rpc-middleware-stream@2.1.0
 * [new tag]           json-rpc-middleware-stream@2.1.1 -> json-rpc-middleware-stream@2.1.1
 * [new tag]           json-rpc-middleware-stream@3.0.0 -> json-rpc-middleware-stream@3.0.0
  • All json-rpc-middleware-stream tags in core:
❯ git ls-remote --tags origin | grep 'json-rpc-middleware-stream'
7c74b62136846a2d8ab12df8fe94679776ec03ef        refs/tags/@metamask/json-rpc-middleware-stream@5.0.1
20054ab903ec1f3100a2e3988db477ae706ab792        refs/tags/@metamask/json-rpc-middleware-stream@6.0.0
ee547eb7c129f8626b3d15b7b35a69fa6a48e963        refs/tags/json-rpc-middleware-stream@1.0.0
a03996a2b49ca51f9eb9f3459521b05fb4b157d7        refs/tags/json-rpc-middleware-stream@1.0.1
095c71e60d53ed8462af75463392ddb463a74f79        refs/tags/json-rpc-middleware-stream@2.0.0
3fea0d2c1b7341fb3364b7c6ccc02769611d96af        refs/tags/json-rpc-middleware-stream@2.1.0
9870a2b04740194d99666e76318647ebd038c048        refs/tags/json-rpc-middleware-stream@2.1.1
09ee1574bc7a55b391ea3585f7c63b5a5f6e1081        refs/tags/json-rpc-middleware-stream@3.0.0
6f97223c00e0510984d83e2a095f8ddc4cf22a21        refs/tags/json-rpc-middleware-stream@4.0.0
e0a98dba249feacad8af93944c4bc5d36d666b5b        refs/tags/json-rpc-middleware-stream@4.1.0
d90fe43d6fb7b5e46a7faf212344fb2fe49ea10a        refs/tags/json-rpc-middleware-stream@4.2.0
e08455ca83f9d3ad9ec117a9c52409175671b38c        refs/tags/json-rpc-middleware-stream@4.2.1
f72900133c1116ea74271f580737463e1abb9817        refs/tags/json-rpc-middleware-stream@4.2.2
8c6b70e5c904d732ec50fa17a17225d55d59a132        refs/tags/json-rpc-middleware-stream@4.2.3
c34b17040a4e5d7682babe79b31f141642834c27        refs/tags/json-rpc-middleware-stream@5.0.0
38c007a30395b2bd50a55fdec2217edfd10886ea        refs/tags/json-rpc-middleware-stream@5.0.1

@MajorLift
Copy link
Contributor Author

Closing as COMPLETED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant