Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accounts-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency #2062

Closed
mcmire opened this issue Nov 17, 2023 · 1 comment · May be fixed by #4449
Closed

[accounts-controller] @metamask/keyring-controller should be a runtime dependency, not a development dependency #2062

mcmire opened this issue Nov 17, 2023 · 1 comment · May be fixed by #4449
Labels
bug Something isn't working team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Nov 17, 2023 •
edited
Loading

It's already a peer dependency, so it should be a runtime dependency too.
@mcmire mcmire added team-wallet-framework bug Something isn't working labels Nov 17, 2023
@mcmire mcmire mentioned this issue Jun 21, 2024
Draft
3 tasks
@kanthesha kanthesha assigned kanthesha and unassigned kanthesha Jun 28, 2024
@kanthesha
Copy link
Contributor

This is already completed.

core/packages/accounts-controller/package.json

Line 48 in 19b704c

"@metamask/keyring-controller": "^17.1.0",
.
We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Categorize type-only and controller-messaged deps correctly MetaMask/core
2 participants
@mcmire @kanthesha