CAIP Multichain API with permission refactor changes #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Donesky <adonesky@gmail.com>
…ccounts.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
… caip25-permission-refactor
…rings are supported
…th-permission-refactor
adonesky1
reviewed
Nov 21, 2024
Comment on lines
65
to
67
| const scopeObject = getSessionScopes(caveat.value)[ | ||
| scope as InternalScopeString | ||
| ]; |
There was a problem hiding this comment.
Hmmm when I first read this I thought it was a bit strange to rehydrate this and then have a method authorization check since our permissions are really not method oriented now... But hmmm maybe its still correct since we still need to validate that the requested method is supported
There was a problem hiding this comment.
Yeah, we still need to keep the interface consistent. I.e. trying to call a scope/method via wallet_invokeMethod that wasn't returned to you via wallet_createSession / wallet_sessionChanged should throw an unauthorized error rather than a method not found error
adonesky1
reviewed
Nov 21, 2024
adonesky1
reviewed
Nov 21, 2024
| * e.g. We flatten each reference into its own scopeObject before storing them in a `endowment:caip25` permission. | ||
| * we resolve the `references` property into a scopeObject per reference and | ||
| * assign an empty array to the `accounts` property if not already defined | ||
| * to more easily read chain specific permissions. |
There was a problem hiding this comment.
Feels like we should call out how/why this type is used since we have 3 of them now 🤣 .
- return type for
getSession - type used for validation pre-serialization?
adonesky1
reviewed
Nov 21, 2024
packages/multichain/src/adapters/caip-permission-adapter-session-scopes.ts
Show resolved
Hide resolved
adonesky1
reviewed
Nov 21, 2024
packages/multichain/src/adapters/caip-permission-adapter-session-scopes.ts
Show resolved
Hide resolved
…on-scopes.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
…on-scopes.ts Co-authored-by: Alex Donesky <adonesky@gmail.com>
…n wallet_invokeMethod
…ion-refactor' into caip-multichain-api-with-permission-refactor
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This diff is a bit messy since it also brings in the core PR that refactors the CAIP-25 permission which the caip-multichain-api branch doesn't have yet.The main thing this PR does is adds
getSessionScopes()which massages the new CAIP-25 permission into aNormalizedScopesObjectReferences
Changelog
@metamask/package-a@metamask/package-bChecklist