Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better way to represent arguments that are tuples #7

Open
danjm opened this issue Apr 4, 2019 · 0 comments
Open

Need a better way to represent arguments that are tuples #7

danjm opened this issue Apr 4, 2019 · 0 comments

Comments

@danjm
Copy link
Contributor

danjm commented Apr 4, 2019

Encodings of contract arguments can include tuples (and tuples within tuples, etc.)

An example signature: fillOrder((address,address,address,address,uint256,uint256,uint256,uint256,uint256,uint256,bytes,bytes),uint256,bytes)

After #6, we represent the arguments in the tuple flatly, on equal level to the other args. This could be misleading if the tuple was representing a struct, for example.

We will need to improve this, but I am not sure what the correct representation of the tuples should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants