Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React UI: Add Unit Testing to Component Template Using Testing Library in MetaMask Design System Monorepo #24

Open
georgewrmarshall opened this issue Oct 3, 2024 · 2 comments

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Oct 3, 2024

Description

Add unit testing functionality to the component template in the MetaMask design system monorepo. This will involve setting up tests using the React Testing Library to ensure that all UI components are covered by unit tests during development.

Technical Details

  • Integrate React Testing Library into the component template within the MetaMask design system monorepo.
  • Create example unit tests for the existing component template as a reference for future component development.
  • Update the component template to automatically include unit tests for new components.
  • Ensure that unit tests are included in the CI pipeline for continuous testing and coverage.
  • Provide documentation or examples on writing unit tests for components in the design system.

Acceptance Criteria

  • React Testing Library is successfully integrated into the component template.
  • New components created using the template automatically include a basic unit test.
  • Unit tests should run automatically as part of the CI process, blocking code with failing tests from being merged. - Already does good to check

References

@georgewrmarshall georgewrmarshall changed the title Add Unit Testing to Component Template Using React Testing Library in MetaMask Design System Monorepo React UI: Add Unit Testing to Component Template Using Testing Library in MetaMask Design System Monorepo Oct 3, 2024
@georgewrmarshall
Copy link
Contributor Author

Has a dependency on the component template

@georgewrmarshall
Copy link
Contributor Author

Create another ticket: - Documentation and examples on how to write unit tests for components are added to the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant