Skip to content

Commit

Permalink
fix: edit button on confirmation page for send ERC-1155 token (#27004)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpuri authored Sep 12, 2024
1 parent 8816378 commit 36f96ae
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
7 changes: 0 additions & 7 deletions test/e2e/tests/tokens/nft/send-nft.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,6 @@ describe('Send NFT', function () {
tag: 'button',
});

// Ensure that this type of NFT is not editable for now
// https://github.com/MetaMask/metamask-extension/issues/24320
const editButtonPresent = await driver.isElementPresent(
'[data-testid="confirm-page-back-edit-button"]',
);
assert.equal(editButtonPresent, false);

// Confirm the send
await driver.clickElement({ text: 'Confirm', tag: 'button' });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ export default function ConfirmTokenTransactionSwitch({ transaction }) {
decimals={decimals}
image={tokenImage}
tokenAddress={tokenAddress}
onEdit={async ({ txData }) => {
const { id } = txData;
await dispatch(
editExistingTransaction(AssetType.NFT, id.toString()),
);
dispatch(clearConfirmTransaction());
history.push(SEND_ROUTE);
}}
toAddress={toAddress}
tokenAmount={tokenAmount}
tokenId={tokenId}
Expand Down

0 comments on commit 36f96ae

Please sign in to comment.