Skip to content

Commit

Permalink
fix: fix typo in pre-build-mv2 and changed value of ENABLE_CONFIRMATI…
Browse files Browse the repository at this point in the history
…ON_REDESIGN (#25258)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Small fix for `pre-build-mv2` description and
`ENABLE_CONFIRMATION_REDESIGN` value in circle ci

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25258?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
DDDDDanica authored Jun 13, 2024
1 parent 92e6b94 commit bb71b24
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -568,10 +568,10 @@ jobs:
name: build:debug
command: find dist/ -type f -exec md5sum {} \; | sort -k 2
- run:
name: Move mmi build to 'dist-mv2' to avoid conflict with production build
name: Move mm build to 'dist-mv2' to avoid conflict with production build
command: mv ./dist ./dist-mv2
- run:
name: Move mmi zips to 'builds-mv2' to avoid conflict with production build
name: Move mm zips to 'builds-mv2' to avoid conflict with production build
command: mv ./builds ./builds-mv2
- store_artifacts:
path: builds-mv2
Expand Down Expand Up @@ -859,7 +859,7 @@ jobs:
at: .
- run:
name: Build extension for testing
command: ENABLE_CONFIRMATION_REDESIGN=1 yarn build:test
command: ENABLE_CONFIRMATION_REDESIGN=true yarn build:test
- run:
name: Move test build to 'dist-test' to avoid conflict with production build
command: mv ./dist ./dist-test-confirmations
Expand All @@ -881,7 +881,7 @@ jobs:
at: .
- run:
name: Build extension for testing
command: ENABLE_CONFIRMATION_REDESIGN=1 yarn build:test:mv2
command: ENABLE_CONFIRMATION_REDESIGN=true yarn build:test:mv2
- run:
name: Move test build to 'dist-test-confirmations-mv2' to avoid conflict with production build
command: mv ./dist ./dist-test-confirmations-mv2
Expand Down Expand Up @@ -1086,7 +1086,7 @@ jobs:
fi
no_output_timeout: 5m
environment:
ENABLE_CONFIRMATION_REDESIGN: 1
ENABLE_CONFIRMATION_REDESIGN: true
- store_artifacts:
path: test-artifacts
destination: test-artifacts
Expand Down Expand Up @@ -1372,7 +1372,7 @@ jobs:
fi
no_output_timeout: 5m
environment:
ENABLE_CONFIRMATION_REDESIGN: 1
ENABLE_CONFIRMATION_REDESIGN: true
- store_artifacts:
path: test-artifacts
destination: test-artifacts
Expand Down

0 comments on commit bb71b24

Please sign in to comment.