Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559 UI - Wire Up Busy Network Warning #11307

Open
darkwing opened this issue Jun 15, 2021 · 7 comments
Open

EIP-1559 UI - Wire Up Busy Network Warning #11307

darkwing opened this issue Jun 15, 2021 · 7 comments
Assignees
Labels
EIP-1559 Tasks required to complete 1559 support
Milestone

Comments

@darkwing
Copy link
Contributor

https://www.figma.com/file/NXvUKcZ0Ocu1GPcT7VxRMx/1559---Gas-Controls?node-id=643%3A5

BusyNetworkWarning

@darkwing darkwing added the EIP-1559 Tasks required to complete 1559 support label Jul 8, 2021
@darkwing darkwing changed the title EIP-1559 UI - Implement Busy Network Warning EIP-1559 UI - Wire Up Busy Network Warning Jul 8, 2021
@darkwing
Copy link
Contributor Author

darkwing commented Jul 8, 2021

When real data exists, we'll need to pipe that information into the EditGasDisplay component as a warning.

@brad-decker brad-decker added this to the EIP 1559 milestone Jul 9, 2021
@darkwing
Copy link
Contributor Author

@danjm @brad-decker Do we presently have a method for detecting this case?

@danjm
Copy link
Contributor

danjm commented Jul 13, 2021

Blocked by eth_feeHistory being available from infura

@danjm danjm added the blocked label Jul 13, 2021
@danjm danjm removed the blocked label Sep 13, 2021
@danjm danjm modified the milestones: EIP 1559, EIP-1559-Next Sep 13, 2021
@danjm
Copy link
Contributor

danjm commented Sep 21, 2021

There will be a few different pieces of this:

  • add a method to the gas fee controller that simply requests eth_feeHistory and returns the result
  • add a helper function to the gas fee controller helpers/utils file that uses the result of eth_feeHistory to calculate whether the network is busy or not
  • (possibly... this might need more thought) include eth_feeHistory in the gas fee controller state, and have it be requested and updated during the polling in that controller
  • dependent on whether do the immediately above bullet, add an indication of whether the network is busy to the gas fee controller state
  • once the above changes are made, update the controllers repo
  • update the version of the controllers repo in the extension
  • use the new data available to show the warning in the above designs

@danjm
Copy link
Contributor

danjm commented Sep 21, 2021

add a helper function to the gas fee controller helpers/utils file that uses the result of eth_feeHistory to calculate whether the network is busy or not

This might require some discussion

@danjm
Copy link
Contributor

danjm commented Sep 21, 2021

@danjm
Copy link
Contributor

danjm commented Sep 21, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-1559 Tasks required to complete 1559 support
Projects
None yet
Development

No branches or pull requests

4 participants