[Bug]: Failing Transactions don't display a Warning anymore and set an insane amount of Gas fees

[seaona]

Describe the bug

Problem: when a tx is going to fail, it displays an insane amount of Gas fees and no warning:

We used to display a warning, like this:

Steps to reproduce

1. Select Mainnet
2. Go to https://etherscan.io/token/0xdac17f958d2ee523a2206206994597c13d831ec7#writeContract
3. Connect MM
4. Click Deprecate
5. Add an address
6. Check MM

Error messages or log output

No response

Version

10.24.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

[bschorchit]

Oh, I see a warning in your first screenshot and also got one when going through the repro steps (screenshot). I think there are some other screens where no warning is being shown.

[bschorchit]

Repro steps for no warning being shown + insane gas fee (in MM v10.23.1):

1. Go to https://etherscan.io/address/0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d#writeContract
2. Connect your wallet
3. Go to approve and input a random address and a random token id (I used 1, it's important that you don't actually own that NFT)
4. Click on Write
5. Notice the insane gas fee but no warning

[bschorchit]

Finding from Dan M.:

So we still have this warning, and it is still working, but NOT if the new EIP-1559 gas UI setting is set to true

[danjm]

I am 95% sure that the root cause of this is the same as the root cause of #17377

[danjm]

@VSaric I am assigning you to this as well, because I think that it will be resolved by the same fix that resolves #17377

cc @ElvirCe

Also, I am pretty sure that the problematic section of code is in confirm-transaction-base.component.js:

rows={[
  renderSimulationFailureWarning &&
    !this.supportsEIP1559V2 &&
    simulationFailureWarning(),
  !renderSimulationFailureWarning &&
    !isMultiLayerFeeNetwork &&
    renderGasDetailsItem(),
  !renderSimulationFailureWarning && isMultiLayerFeeNetwork && (
    <MultiLayerFeeMessage
      transaction={txData}
      layer2fee={hexMinimumTransactionFee}
      nativeCurrency={nativeCurrency}
    />
  ),