You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name of the onNetworkStateChange option along with the way that it's used doesn't match what method is being used to listen to the network. Currently we configure TransactionController to listen for the network ID to change, and when this happens, it will refresh its state based on the current network. However, this is the only controller for which we use network ID to know when the network has changed; usually we either use the networkDidChange event or we listen for the whole NetworkController state to change. We should pick one of these that is more appropriate. We should probably also onNetworkStateChange if we are not going to listen for the whole NetworkController state to change.
The text was updated successfully, but these errors were encountered:
@jiexi@shanejonas@mcmire Does MetaMask/core#3643 partially or fully resolve this issue, now that TransactionController listens to NetworkController:stateChange via the messaging system?
The name of the
onNetworkStateChange
option along with the way that it's used doesn't match what method is being used to listen to the network. Currently we configure TransactionController to listen for the network ID to change, and when this happens, it will refresh its state based on the current network. However, this is the only controller for which we use network ID to know when the network has changed; usually we either use thenetworkDidChange
event or we listen for the whole NetworkController state to change. We should pick one of these that is more appropriate. We should probably alsoonNetworkStateChange
if we are not going to listen for the whole NetworkController state to change.The text was updated successfully, but these errors were encountered: