fetchErc20Decimals should not use getTokenStandardAndDetails

[dbrans]

We are making 3-4 additional RPC requests for each ERC20 token during simulation renders. Given that 90% of transactions involve only a single token, and many of these are not ERC20 tokens, this extra load is generally manageable. However, for the 10% of transactions involving multiple ERC20 tokens, this can quickly add up.

For example, transactions with 10 or more tokens could result in 20-30 additional requests, which might impact performance and rate limits.

@bergeron wrote:

I do suspect getTokenStandardAndDetails is used in some places it shouldn't. It should only be used when we have an address and no idea what kind of token it is. Because it has to cycle through all the standards. For example this code just wants ERC20 decimals:

async function fetchErc20Decimals(address: Hex): Promise<number> {
  try {
    const { decimals } = await getTokenStandardAndDetails(address);
    return decimals ? parseInt(decimals, 10) : ERC20_DEFAULT_DECIMALS;
  } catch {
    return ERC20_DEFAULT_DECIMALS;
  }
}

Which should be 1 RPC request since we already 'know' its an ERC20, but that could do up to 4 RPC requests (checking for NFTs and returning other ERC20 details other than decimals)

[bschorchit]

Data insight: transaction with 10+ tokens are represent less than 0.1%

[digiwand]

moved from epic Simulations to epic 2024 Q3 - Confirmation Performance as the issue involves additional instances outside of simulations

[metamaskbot]

Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27088 which has this release label.