Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Signature Redesign] SIWE: Copy updates #25319

Closed
9 tasks
bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25381
Closed
9 tasks

[Signature Redesign] SIWE: Copy updates #25319

bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25381
Assignees
@jpuri
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team type-enhancement

Comments

@bschorchit
Copy link

What is this about?

We should update the copy for SIWE to match the final copy.

Scenario

  • Go to test dapp
  • Click on Sign In With Ethereum

Design

Figma file

Screenshot 2024-06-14 at 08 47 31

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@bschorchit bschorchit added type-enhancement team-confirmations Push issues to confirmations team labels Jun 14, 2024
@jpuri jpuri self-assigned this Jun 14, 2024
@jpuri jpuri mentioned this issue Jun 18, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team type-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: copy changes in re-designed SIWE signature pages MetaMask/metamask-extension
3 participants
@jpuri @bschorchit @metamaskbot