CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

I noticed that this test was still taking a long time on Chrome so I did some more manual testing and it appears as though (assuming you kill local ganache):

1. Click the send button in test dapp
2. (random, sometimes long wait time)
3. The confirmation eventually pops up

Spying on the service worker between clicking the send button and the confirmation finally coming up, it appears the confirmation doesn't appear until the following network request(s) complete:

• https://tx-sentinel-ethereum-mainnet.api.cx.metamask.io/networks
• https://gas.api.cx.metamask.io/networks/1337/suggestedGasFees

When trying to send a transaction on a network with dead RPC, I see 2 RPC calls that each take ~5 seconds to fail, which together cause the ~10 second delay in receiving the metamask popup:

• Click send on test dapp
• extension executes addTransactionWithController
• Calls TransactionController.addTransaction
  • determineTransactionType runs the eth_getCode RPC query
  • updateGasProperties runs the eth_estimateGas RPC query

I don't know why the RPC queries take 5 seconds instead of failing fast. Perhaps somewhere lower level is doing retry. But that's the only code I see slowing down the popup.

on the test environment I am seeing a great amount of requests for mostly eth_estimateGas, eth_gasPrice and eth_blockNumber. Those return very fast, but we keep making requests until ~10seconds.

and on the dev build from this branch, I am seeing a similar behaviour as I see in production: sometimes the popup is open fast, but sometimes it takes ~5 seconds

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (4a9c480) to head (84786eb).
Report is 25 commits behind head on develop.

@@             Coverage Diff             @@
##           develop   #25425      +/-   ##
===========================================
- Coverage    69.57%   69.56%   -0.01%     
===========================================
  Files         1360     1360              
  Lines        48172    48177       +5     
  Branches     13296    13296              
===========================================
  Hits         33513    33513              
- Misses       14659    14664       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.