Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Signature SIWE: add non-critical alert for account missmatch #25317

Closed
9 tasks
bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25613
Closed
9 tasks

Redesign Signature SIWE: add non-critical alert for account missmatch #25317

bschorchit opened this issue Jun 14, 2024 · 0 comments · Fixed by #25613
Assignees
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team type-enhancement

Comments

@bschorchit
Copy link

What is this about?

On SIWE, we currently have a warning for account missmatch. We should migrate this over to the new alert system.

Scenario

  • Go to test dapp
  • Under Sign In With Ethereum, click on Sign In With Ethereum (Bad account) button
  • See our SIWE confirmation with a warning

Design

Figma

Screenshot 2024-06-14 at 08 22 29

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-confirmations Push issues to confirmations team type-enhancement
Projects
None yet
3 participants