Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Batch request error smartTransaction:showSmartTransactionStatusPage #25796

Closed
Pasha8914 opened this issue Jul 12, 2024 · 3 comments
Closed
Labels
external-contributor regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug

Comments

@Pasha8914
Copy link

Pasha8914 commented Jul 12, 2024

Describe the bug

When sending a batch of transaction requests, an error occurs on the second transaction. However, the transaction is mined successfully.

Expected behavior

When sending a batch of transaction requests, it should be processed without errors, and the transaction hash must be returned

Screenshots/Recordings

smart-account-bug.mp4

Steps to reproduce

  1. Run project
  2. Click Send self-tx
  3. Sign first transaction
  4. Sign second transaction as soon as the signature button is unlocked.

Error messages or log output

Request of type 'smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait.

Version

11.16.14

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

  • The functionality of services that send a large number of consecutive transactions is blocked, making the services unusable.
  • An error will appear in the interface, but the transaction will actually be sent, which may result in a loss of funds for the user.
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jul 12, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jul 12, 2024
@metamaskbot metamaskbot added external-contributor regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 labels Jul 12, 2024
@danjm danjm added the team-transactions Transactions team label Jul 12, 2024
@forest-diggs-consensys
Copy link

This is fixed in v12, though a transaction hash is only returned once a transaction is finalized. For context, this is to account for the case of dropped/automatically cancelled transactions (ie. if we detect a transaction would revert). This case is handled the same as if a user rejected the first transaction. Following that, the user will be able to confirm the 2nd queued transaction.

@Pasha8914
Copy link
Author

Pasha8914 commented Jul 15, 2024

This is fixed in v12, though a transaction hash is only returned once a transaction is finalized. For context, this is to account for the case of dropped/automatically cancelled transactions (ie. if we detect a transaction would revert). This case is handled the same as if a user rejected the first transaction. Following that, the user will be able to confirm the 2nd queued transaction.

when to expect the release of version 12

@anaamolnar anaamolnar added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Jul 15, 2024
@klejeune
Copy link
Contributor

Version 12 has been released, the current version is 12.2.4.

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 19, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.16.14 Regression bug that was found in production in release 11.16.14 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug
Projects
Archived in project
Development

No branches or pull requests

6 participants