-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Certain PPOM signatures are not functioning as expected. #27905
Comments
On the latest
Console error
No console error and only the following are not flagged:
Ethereum.Mainnet.Chrome.movzksyn.chrome.mov |
The errors should recently have been fixed with this PR: #27939. As @Unik0rnMaggie reported they are not, we should investigate what might be causing failures on Ethereum cc: @jpuri . It not behaving correctly on other networks is likely because the current address used on those request is not a valid token/nft on those networks. |
@Unik0rnMaggie
Not flagged:
|
I checked with latest code in develop branch today and all malicious transactions except |
Hi Team, As per chat with @jpuri it seems the errors might occur due to missing access on provider for my Infura Key. With the production Infura key I do not experience any errors. @bschorchit would it be possible to receive the access on my Infura key to verify if the error persists? Thank you |
Closing as this is not an issue with the production Infura key! We can re-open if we encounter this again. @Unik0rnMaggie I'll follow up with you re: permissions for Infura key on slack |
Describe the bug
Malicious ERC 20 Approval (BUSD)
,Malicious Set Approval for All,
andMalicious ERC20 Approval with Odd Hex Data
are not being identified by PPOM.Not sure if that's expected but the token name on BNB is displayed as
anyUSDC
and in RC 12.5.0Malicious ERC 20 Approval (BUSD)
is not flagged (account has enough USDC).Expected behavior
Screenshots/Recordings
Steps to reproduce
Malicious ERC 20 Approval (BUSD)
,Malicious Set Approval for All,
orMalicious ERC20 Approval with Odd Hex Data
Error messages or log output
No response
Detection stage
In production (default)
Version
develop
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: