Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding e2e tests for NFT permit #28004

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

chore: adding e2e tests for NFT permit #28004

wants to merge 21 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 22, 2024

Description

Adding e2e tests for NFT permit.

Related issues

Fixes: #27908

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 22, 2024
@jpuri jpuri requested review from a team as code owners October 22, 2024 11:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title fest: Adding e2e for NFT permit fest: adding e2e tests for NFT permit Oct 22, 2024
@jpuri jpuri changed the title fest: adding e2e tests for NFT permit chore: adding e2e tests for NFT permit Oct 22, 2024
Copy link

socket-security bot commented Oct 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/test-dapp@8.12.0 None 0 16.9 MB mcmire

🚮 Removed packages: npm/@metamask/test-dapp@8.7.0

View full report↗︎

@jpuri jpuri enabled auto-merge October 25, 2024 15:51
@metamaskbot
Copy link
Collaborator

Builds ready [6420fc8]
Page Load Metrics (1892 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15862318189515976
domContentLoaded15762192185314268
load15862323189216378
domInteractive179241209
backgroundConnect8136393216
firstReactRender481931053316
getState570182110
initialActions01000
loadScripts11371629137611655
setupStore11125313014
uiStartup189730622132241116
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for ERC-721 permit
3 participants