-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable security alerts api #28040
Open
vinistevam
wants to merge
12
commits into
develop
Choose a base branch
from
feat/vs-2516
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+112
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
github-actions
bot
added
the
team-confirmations
Push issues to confirmations team
label
Oct 23, 2024
matthewwalsh0
previously approved these changes
Oct 23, 2024
jpuri
previously approved these changes
Oct 23, 2024
Builds ready [93bfff7]
Page Load Metrics (2120 ± 230 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
force-pushed
the
feat/vs-2516
branch
from
October 25, 2024 08:12
e995989
to
fb07ead
Compare
vinistevam
force-pushed
the
feat/vs-2516
branch
from
October 25, 2024 09:41
fb07ead
to
b3e0fbb
Compare
vinistevam
force-pushed
the
feat/vs-2516
branch
3 times, most recently
from
October 25, 2024 16:11
6c6a8f4
to
92ae04c
Compare
Builds ready [fff2fcc]
Page Load Metrics (1976 ± 57 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
force-pushed
the
feat/vs-2516
branch
from
October 26, 2024 05:21
fff2fcc
to
121b8fe
Compare
Builds ready [121b8fe]
Page Load Metrics (2039 ± 111 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5400b8a]
Page Load Metrics (1979 ± 127 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to enable the Security Alerts API. The environment variable
SECURITY_ALERTS_API_ENABLED
will be maintained and removed in a separate PR in a future release.There is a fallback mechanism that uses the local PPOM to validate the request in the case of an issue with the API. This safeguard is designed to prevent any disruption or impact on the user experience.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2516
Manual testing steps
security-alerts
and find the call to the API service.Screenshots/Recordings
test-security-alerts-api.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist