-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: allow more simple findElement by data-testid #28065
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [79119ff]
Page Load Metrics (2103 ± 86 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow this helps a lot..
Description
Allows you to convert code like
into
It cannot handle these two more complex cases, so just leave them as is:
'[data-testid="aaa"] input'
'button[data-testid="aaa"]'
Related issues
Manual testing steps
Try some conversions in spec files
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist