-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken test Vault Decryptor Page is able to decrypt the vault uploading the log file in the vault-decryptor webapp
#28098
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Vault Decryptor Page is able to decrypt the vault uploading the log file in the vault-decryptor webapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for the fix!
Builds ready [4228d95]
Page Load Metrics (2204 ± 62 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
The Vault Decrypt test is broken because whenever we turn Basic Functionality Off, now it also disables the Profile Sync.
This didn't happen before, so we had to do an extra step for disabling Profile Sync manually.
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/107857/workflows/f954137e-9365-4e96-a51c-30b5f5eb3ff8/jobs/4032451/tests#failed-test-0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
See how the Profile Sync is already disabled after turning off the Basic Functionality toggle
Pre-merge author checklist
Pre-merge reviewer checklist