fix: broken test Vault Decryptor Page is able to decrypt the vault uploading the log file in the vault-decryptor webapp

[seaona]

Description

The Vault Decrypt test is broken because whenever we turn Basic Functionality Off, now it also disables the Profile Sync.
This didn't happen before, so we had to do an extra step for disabling Profile Sync manually.

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/107857/workflows/f954137e-9365-4e96-a51c-30b5f5eb3ff8/jobs/4032451/tests#failed-test-0

Related issues

Fixes:

Manual testing steps

1. Check ci run https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/107865/workflows/712ff9da-5201-4e50-9c6b-f60bfeebb01c/jobs/4032810

Screenshots/Recordings

See how the Profile Sync is already disabled after turning off the Basic Functionality toggle

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[chloeYue]

LGTM ! Thanks for the fix!

[metamaskbot]

Builds ready [4228d95]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2204 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	340	2477	2111	427	205
		domContentLoaded	1921	2461	2158	121	58
		load	1934	2476	2204	130	62
		domInteractive	29	140	53	25	12
		backgroundConnect	10	90	42	31	15
		firstReactRender	59	290	112	47	23
		getState	7	90	27	26	12
		initialActions	0	1	0	0	0
		loadScripts	1417	1875	1594	103	49
		setupStore	15	104	46	29	14
		uiStartup	2190	2804	2458	152	73

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[mikesposito]

Looks good!