Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Cancel all" button for stalled transactions #4022

Open
danfinlay opened this issue Apr 18, 2018 · 8 comments
Open

Add "Cancel all" button for stalled transactions #4022

danfinlay opened this issue Apr 18, 2018 · 8 comments
Assignees
Labels

Comments

@danfinlay
Copy link
Contributor

Sometimes a user keeps submitting new transactions when the network is slow, then finds out these are all valid transactions!

A "cancel all" button would submit null transactions for all pending transactions, but with higher gas prices.

@danfinlay danfinlay added type-enhancement needs-design Needs design support. labels Apr 18, 2018
@danfinlay danfinlay added this to the Sprint 05 milestone Apr 18, 2018
@cjeria
Copy link
Contributor

cjeria commented Apr 18, 2018

We'd probably need to display a "total cost" for submitting null transactions but with higher gas prices. This button might also be placed above history somewhere or at least within settings as a starting point while we figure out where to place this button in the new retry tx designs.

@CruzMolina
Copy link

Related to #3756. Can also occur when a very low gas price (1 Gwei) tx is attempted. Importing the wallet's mnemonic into another browser on the same system or the same browser on a different system clears up the clog and sends out all the valid stuck pending tx's.

@schmijos
Copy link

schmijos commented Aug 8, 2018

This would also be helpful for me to develop Dapps. I made a mistake and I've now 300 pending transactions 😢

@bdresser
Copy link
Contributor

bdresser commented Aug 8, 2018

will probably be handled in MetaMask/Design#25

@bdresser
Copy link
Contributor

This should probably have a custom confirmation screen

  • may want to show each tx hash that's getting cancelled (and links to etherscan) - this could replace the primary value up top?
  • we should suggest a gas high enough to beat out everything pending, but still allow the gas "edit" link
  • what should we show as the recipient address?
  • "gas fee" and "total" will be the same, maybe we can remove one? ("total gas fee") ?
  • should add an article somewhere about why cancelling requires gas
  • could hard-code "CANCEL ALL" or "CANCEL PENDING TRANSACTIONS" in the pill that usually displays the function name

@bdresser
Copy link
Contributor

bdresser commented Sep 7, 2018

from an older duplicate issue

image

also, copying this wireframe from MetaMask/Design#30 that I think could be very similar to what we could show for a "cancel all" feature. We could show the pending tx that'd be cancelled, show the gas it will require for each, then sum it up at the bottom. Probably don't want to allow de-selection as it'd cause some nonce issues. This would be a slightly more robust view than repurposing the Confirm screen, but it'd also give the user much more detail.

image

So to sum up all this word-sauce, I think there are two options:
(1) repurpose the Confirm screen, try to cram in relevant info
(2) build a new screen that displays multiple tx; could be re-used for submitting batch transactions

@danfinlay
Copy link
Contributor Author

re: step 4: We only need to increase the gas price >=10% over the replaced tx for all known node types to accept it as a replacement. Anything more is over-paying.

@danfinlay
Copy link
Contributor Author

You know what would be great? If a single tx could span nonces. That way, a single "cancellation tx" with high gas could invalidate all of these other pending transactions.

@bdresser bdresser removed this from the Sprint 05 milestone Dec 12, 2018
@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants